| Date | Wed, 9 Jan 2013 19:49:52 +0530 | Subject | Re: [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function | From | Viresh Kumar <> |
| |
n 9 January 2013 19:20, Vinod Koul <vinod.koul@intel.com> wrote: >> +static inline bool is_slave_xfer(enum dma_transfer_direction direction) >> +{ >> + return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM); >> +} > After reading the subsequent patch I understand what is intent here. Perhaps > is_slave_dirn() would have been a beter one...
dirn isn't readable, it took me some time to understand the intent... Either have xfer or direction :)
|