lkml.org 
[lkml]   [2013]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: add Packet hub driver for Topcliff Platform controller hub
On Tue, Jan 08, 2013 at 10:49:14AM +0000, Arnd Bergmann wrote:
> On Monday 07 January 2013, Dan Carpenter wrote:
> > Sorry my question is about an old patch. Smatch complains because we
> > only pass a PAGE_SIZE buffer to sysfs files so the test for
> > "if (count > PCH_PHUB_OROM_SIZE) {" makes it think we are overflowing.
> > In fact, count is never more than 4096 so there is no overflow, but I
> > also think that it means only the first 4096 bytes of the firmware gets
> > updated.
>
> I think it works correctly as long as user space keeps writing into the
> bin file when getting short write return (4096 bytes).
>

Ah. Ok. I misunderstood. I've looked through it again and you're
right.

Sorry for the noise.

regards,
dan carpenter



\
 
 \ /
  Last update: 2013-01-08 13:21    [W:0.724 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site