lkml.org 
[lkml]   [2013]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/32] aio: remove retry-based AIO
On Sat, Dec 29, 2012 at 03:36:38PM +0800, Hillf Danton wrote:
> On Thu, Dec 27, 2012 at 9:59 AM, Kent Overstreet <koverstreet@google.com> wrote:
> > - /*
> > - * This is so that aio_complete knows it doesn't need to
> > - * pull the iocb off the run list (We can't just call
> > - * INIT_LIST_HEAD because we don't want a kick_iocb to
> > - * queue this on the run list yet)
> > - */
> > - iocb->ki_run_list.next = iocb->ki_run_list.prev = NULL;
>
> The tricky, list.next = NULL, is erased here, but it is reused in one of
> the subsequent patches, why?

I think you're confusing the two different linked lists - there's
ki_run_list, which isn't used anymore after this patch (and deleted
here), and ki_list, which is used for cancellation.

Yeah, it's tricky and ugly.


\
 
 \ /
  Last update: 2013-01-08 00:01    [W:0.146 / U:5.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site