lkml.org 
[lkml]   [2012]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 04/32] aio: remove retry-based AIO
From
On Thu, Dec 27, 2012 at 9:59 AM, Kent Overstreet <koverstreet@google.com> wrote:
> @@ -1585,18 +1278,27 @@ static int io_submit_one(struct kioctx *ctx, struct iocb __user *user_iocb,
> * don't see ctx->dead set here, io_destroy() waits for our IO to
> * finish.
> */
> - if (ctx->dead) {
> - spin_unlock_irq(&ctx->ctx_lock);
> + if (ctx->dead)
> ret = -EINVAL;
> + spin_unlock_irq(&ctx->ctx_lock);
> + if (ret)
> goto out_put_req;
> +
> + if (unlikely(kiocbIsCancelled(req))) {
> + ret = -EINTR;
> + } else {
> + ret = req->ki_retry(req);
> }
> - aio_run_iocb(req);
> - if (!list_empty(&ctx->run_list)) {
> - /* drain the run list */
> - while (__aio_run_iocbs(ctx))
> - ;
> + if (ret != -EIOCBQUEUED) {
> + /*
> + * There's no easy way to restart the syscall since other AIO's
> + * may be already running. Just fail this IO with EINTR.
> + */
> + if (unlikely(ret == -ERESTARTSYS || ret == -ERESTARTNOINTR ||
> + ret == -ERESTARTNOHAND || ret == -ERESTART_RESTARTBLOCK))
> + ret = -EINTR;
> + aio_complete(req, ret, 0);
> }
> - spin_unlock_irq(&ctx->ctx_lock);
>
> aio_put_req(req); /* drop extra ref to req */
> return 0;

return ret; yes?


\
 
 \ /
  Last update: 2012-12-29 09:21    [W:0.213 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site