Messages in this thread |  | | Subject | Re: [PATCH 2/5 RESEND] thermal: exynos: Miscellaneous fixes to support falling threshold interrupt | From | Joe Perches <> | Date | Sun, 06 Jan 2013 15:55:22 -0800 |
| |
On Sun, 2013-01-06 at 15:50 -0800, Amit Daniel Kachhap wrote: > Below fixes are done to support falling threshold interrupt, > * Falling interrupt status macro corrected according to exynos5 data sheet. > * The get trend function modified to calculate trip temperature correctly. > * The clearing of interrupt status in the isr is now done after handling > the event that caused the interrupt. [] > diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/exynos_thermal.c [] > @@ -373,12 +373,19 @@ static int exynos_get_temp(struct thermal_zone_device *thermal, > static int exynos_get_trend(struct thermal_zone_device *thermal, > int trip, enum thermal_trend *trend) > { > - if (thermal->temperature >= trip) > + int ret = 0;
Unnecessary initialization
> + unsigned long trip_temp; > + > + ret = exynos_get_trip_temp(thermal, trip, &trip_temp); > + if (ret < 0) > + return ret; > + > + if (thermal->temperature >= trip_temp) > *trend = THERMAL_TREND_RAISING; > else > *trend = THERMAL_TREND_DROPPING;
THERMAL_TREND_STABLE ?
> > - return 0; > + return ret;
return 0 is clearer.
|  |