Messages in this thread | | | Subject | Re: [patch] TTY: synclink, small cleanup in dtr_rts() | From | Joe Perches <> | Date | Sun, 27 Jan 2013 13:00:01 -0800 |
| |
On Sun, 2013-01-27 at 23:19 +0300, Dan Carpenter wrote: > On Sun, Jan 27, 2013 at 12:04:38PM -0800, Joe Perches wrote: > > Wouldn't it be clearer still to use | instead of + > Yeah. I think it would be, but adding bitflags together instead of > doing bitwise ORs is very common as well.
Fortunately, less and less so.
Another option might be to add another #define to include/uapi/linux/synclink.h
#define SerialSignal_DTR_RTS (SerialSignal_DTR | SerialSignal_RTS)
| |