Messages in this thread | | | Date | Tue, 29 Jan 2013 18:49:02 +0100 (CET) | From | Julia Lawall <> | Subject | Re: coccinelle and bitmask arithmetic (was: Re: [patch] TTY: synclink, small cleanup in dtr_rts()) |
| |
How about the following (from today's linux-next). They appear to be trying to do the same calculation, once with + and once with |.
arch/arm/common/it8152.c
int dma_set_coherent_mask(struct device *dev, u64 mask) { if (mask >= PHYS_OFFSET + SZ_64M - 1) return 0;
return -EIO; }
static int it8152_pci_platform_notify(struct device *dev) { if (dev->bus == &pci_bus_type) { if (dev->dma_mask) *dev->dma_mask = (SZ_64M - 1) | PHYS_OFFSET; dev->coherent_dma_mask = (SZ_64M - 1) | PHYS_OFFSET; dmabounce_register_dev(dev, 2048, 4096, it8152_needs_bounce); } return 0; }
julia
| |