| Date | Fri, 25 Jan 2013 17:22:24 +0000 | From | Dave Martin <> | Subject | Re: [PATCH 19/19] [INCOMPLETE] ARM: make return_address available for ARM_UNWIND |
| |
On Fri, Jan 25, 2013 at 12:08:23PM -0500, Steven Rostedt wrote: > On Fri, 2013-01-25 at 16:59 +0000, Dave Martin wrote: > > > Cool. Are you aware of return_address being used elsewhere? Currently > > I'm not aware of anything else which uses it, and grep is not finding > > any calls outside ftrace.h that I can see. > > softirq.c has a trace_preempt_off() use of CALLER_ADDR1. > > kernel/sched/core.c has CALLER_ADDR1, 2 an 3.
These cases look safe to me ... sched/core.c:get_parent_ip() looks like it uses notrace purely to avoid the spurious extra frame which it would otherwise insert, and the code in softirq.c doesn't appear to be in a notrace context.
Am I being too optimistic, or does that match your understanding?
Cheers ---Dave
|