| From | Paul Turner <> | Date | Fri, 25 Jan 2013 08:00:36 -0800 | Subject | Re: [PATCH 05/19] sched: warnings in kernel/sched/fair.c |
| |
On Fri, Jan 25, 2013 at 6:14 AM, Arnd Bergmann <arnd@arndb.de> wrote: > a4c96ae319 "sched: Unthrottle rt runqueues in __disable_runtime()" > turned the unthrottle_offline_cfs_rqs function into a static symbol, > which now triggers a warning about it being potentially unused: > > kernel/sched/fair.c:2055:13: warning: 'unthrottle_offline_cfs_rqs' defined but not used [-Wunused-function] > > Marking it __maybe_unused shuts up the gcc warning and lets the > compiler safely drop the function body when it's not being used. > > To reproduce, build the ARM bcm2835_defconfig. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Peter Boonstoppel <pboonstoppel@nvidia.com> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > Cc: Paul Turner <pjt@google.com> > Cc: Ingo Molnar <mingo@kernel.org> > --- > kernel/sched/fair.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 5eea870..81fa536 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -2663,7 +2663,7 @@ static void destroy_cfs_bandwidth(struct cfs_bandwidth *cfs_b) > hrtimer_cancel(&cfs_b->slack_timer); > } > > -static void unthrottle_offline_cfs_rqs(struct rq *rq) > +static void __maybe_unused unthrottle_offline_cfs_rqs(struct rq *rq)
Looks good.
Reviewed-by: Paul Turner <pjt@google.com>
> { > struct cfs_rq *cfs_rq; > > -- > 1.8.0 >
|