Messages in this thread | | | Date | Fri, 25 Jan 2013 10:10:44 +0000 | Subject | Re: [PATCH 4/4] async: replace list of active domains with global list of pending items | From | James Hogan <> |
| |
On 25 January 2013 10:08, James Hogan <james@albanarts.com> wrote: > On 25 January 2013 01:01, Tejun Heo <tj@kernel.org> wrote: >> Hello, >> >> On Fri, Jan 25, 2013 at 12:13:45AM +0000, James Hogan wrote: >>> Should it have this? >>> + else >>> + INIT_LIST_HEAD(&entry->global_list) >> >> I think it would be better to have INIT_LIST_HEAD() during @entry >> initialization. Heh, I forgot that. I wonder why it didn't crash on >> my machine. Can you please cook up a patch to init both list fields >> right after kzalloc()? > > How does the following patch look? Feel free to squash it into the > original to avoid breaking bisection :).
Sorry, gmail has screwed with the patch. I'll send separately.
Cheers James
| |