lkml.org 
[lkml]   [2013]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] async: replace list of active domains with global list of pending items
Hello,

On Fri, Jan 25, 2013 at 12:13:45AM +0000, James Hogan wrote:
> Should it have this?
> + else
> + INIT_LIST_HEAD(&entry->global_list)

I think it would be better to have INIT_LIST_HEAD() during @entry
initialization. Heh, I forgot that. I wonder why it didn't crash on
my machine. Can you please cook up a patch to init both list fields
right after kzalloc()?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-01-25 02:41    [W:0.054 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site