Messages in this thread | | | Date | Thu, 24 Jan 2013 11:44:07 +0100 | From | Jean-Christophe PLAGNIOL-VILLARD <> | Subject | Re: [PATCH 7/9] ARM: at91/at91_dt_defconfig: remove memory specification to cmdline |
| |
On 09:46 Thu 24 Jan , Nicolas Ferre wrote: > On 01/23/2013 11:20 AM, Jean-Christophe PLAGNIOL-VILLARD : > > On 10:48 Wed 23 Jan , Nicolas Ferre wrote: > >> No need for this cmdline option as we are using DT. > >> Moreover this defconfig is targeted to multiple SoC/boards: this option > >> was nonsense. > > just keep the console the rest is a nonsense too > > > > as on 9g45 the initrd will be at 0x7xxxxxxx > > Understood, but I prefer to keep a "root" option at least, so I keep it > like this. > > > the console too but as the patch serie to support via DT is not yet mainline > > we can keep it > > Ok for this.
I check and the default commande line in the defconfig is a nonsense now
as we will provide a default one via dt anyway
and the root option will not work on 9g45
so it's better to simply drop it
Best Regards, J. > > > > > Best Regards, > > J. > >> > >> Reported-by: Josh Wu <josh.wu@atmel.com> > >> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> > >> --- > >> arch/arm/configs/at91_dt_defconfig | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig > >> index b175577..a353ff6 100644 > >> --- a/arch/arm/configs/at91_dt_defconfig > >> +++ b/arch/arm/configs/at91_dt_defconfig > >> @@ -31,7 +31,7 @@ CONFIG_ZBOOT_ROM_TEXT=0x0 > >> CONFIG_ZBOOT_ROM_BSS=0x0 > >> CONFIG_ARM_APPENDED_DTB=y > >> CONFIG_ARM_ATAG_DTB_COMPAT=y > >> -CONFIG_CMDLINE="mem=128M console=ttyS0,115200 initrd=0x21100000,25165824 root=/dev/ram0 rw" > >> +CONFIG_CMDLINE="console=ttyS0,115200 initrd=0x21100000,25165824 root=/dev/ram0 rw" > >> CONFIG_KEXEC=y > >> CONFIG_AUTO_ZRELADDR=y > >> # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set > >> -- > >> 1.8.0 > >> > > > > > > > -- > Nicolas Ferre
| |