lkml.org 
[lkml]   [2013]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7u1 10/31] x86, 64bit: Don't set max_pfn_mapped wrong value early on native path
From
On Tue, Jan 15, 2013 at 5:48 AM, Stefano Stabellini
<stefano.stabellini@eu.citrix.com> wrote:

>
> If you are going to put a comment like that in the code, could you
> please at least add some useful details, rather than a generic
> "somehow"? It doesn't seem very helpful to me or to any other hackers
> looking at the code.
>
> The issue is even described as a comment in the code at the beginning of
> arch/x86/xen/mmu.c:xen_setup_kernel_pagetable:
>
> /* max_pfn_mapped is the last pfn mapped in the initial memory
> * mappings. Considering that on Xen after the kernel mappings we
> * have the mappings of some pages that don't exist in pfn space, we
> * set max_pfn_mapped to the last real pfn mapped. */
>
> Now if max_pfn_mapped is supposed to represent the last pfn mapped in
> the initial memory mapping, then I think that the way Xen uses
> max_pfn_mapped is actually correct.

change the comments to:

+ /*
+ * Native path, max_pfn_mapped is not set yet.
+ * Xen has valid max_pfn_mapped set in
+ * arch/x86/xen/mmu.c:xen_setup_kernel_pagetable().
+ */


Thanks

Yinghai


\
 
 \ /
  Last update: 2013-01-15 18:21    [W:0.753 / U:2.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site