lkml.org 
[lkml]   [2013]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7u1 04/31] x86, 64bit, mm: add generic kernel/ident mapping helper
    On Thu, Jan 03, 2013 at 04:48:24PM -0800, Yinghai Lu wrote:
    > +int kernel_mapping_init(pgd_t *pgd_page, unsigned long addr, unsigned long end)
    > +{
    > + struct x86_mapping_info info = {
    > + .alloc_pgt_page = alloc_pgt_page,
    > + .pmd_flag = __PAGE_KERNEL_LARGE,
    > + .kernel_mapping = true,
    > + };
    > +
    > + return kernel_ident_mapping_init(&info, pgd_page, addr, end);

    This patch looks good so far except this:
    kernel_ident_mapping_init says it initializes ident mapping but
    this is wrong and the type of mapping is actually controlled by
    info.kernel_mapping.

    So this function which gets &info, etc should be called
    kernel_mapping_init, AFAICT. And wrt the one wrapping
    kernel_ident_mapping_init, I can't seem to find where it is called.
    What's up?

    Thanks.

    --
    Regards/Gruss,
    Boris.


    \
     
     \ /
      Last update: 2013-01-04 23:01    [W:4.046 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site