Messages in this thread | | | From | Linus Torvalds <> | Date | Sun, 9 Sep 2012 08:31:57 -0700 | Subject | Re: mtd: kernel BUG at arch/x86/mm/pat.c:279! |
| |
On Sun, Sep 9, 2012 at 7:56 AM, Suresh Siddha <suresh.b.siddha@intel.com> wrote: > > yes but that is not a valid range I think because of the supported > physical address bit limits of the processor and also the max > architecture limit of 52 address bits.
But how could the caller possibly know that? None of those internal PAT limits are exposed anywhere.
So doing the BUG_ON() is wrong. I'd suggest changing it to an EINVAL.
In fact, BUG_ON() is *always* wrong, unless it's a "my internal data structures are so messed up that I cannot continue".
Linus
| |