Messages in this thread | | | Date | Fri, 7 Sep 2012 17:56:42 -0700 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 04/12] perf diff: Refactor diff displacement possition info |
| |
Em Thu, Sep 06, 2012 at 05:46:58PM +0200, Jiri Olsa escreveu: > @@ -150,6 +154,24 @@ static struct perf_evsel *evsel_match(struct perf_evsel *evsel, > return NULL; > } > > +static void resort_evlist(struct perf_evlist *evlist, bool name)
For consistency, please use:
+static void perf_evlist__resort_hists(struct perf_evlist *evlist, bool name)
> +{ > + struct perf_evsel *evsel; > + > + list_for_each_entry(evsel, &evlist->entries, node) { > + struct hists *hists = &evsel->hists; > + > + hists__output_resort(hists); > + > + /* > + * The hists__name_resort only sets possition > + * if name is false. > + */ > + if (name || ((!name) && show_displacement)) > + hists__name_resort(hists, name);
- Arnaldo
| |