Messages in this thread | | | Date | Sat, 8 Sep 2012 05:50:59 -0700 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 05/12] perf diff: Refactor stdio ui data columns output |
| |
Em Sat, Sep 08, 2012 at 02:35:14PM +0200, Jiri Olsa escreveu: > On Fri, Sep 07, 2012 at 11:55:02AM +0900, Namhyung Kim wrote: > > Hi, Jiri > > > > On Thu, 6 Sep 2012 17:46:59 +0200, Jiri Olsa wrote: > > > Currently for any of the data columns (like Overhead/Period..) in > > > stdio ui, there's separate code to print header/dots/value scattered > > > along the display code path. > > > > > > Adding hists_stdio_column struct to centralize all info needed > > > to print column header/dots/value. > > > > > > This change eases up addition for new columns, which is now mostly > > > matter only of adding new hists_stdio_column struct. > > > > As you may know, I submitted a similar patchset few days ago for the > > same reason and it handles TUI/GTK cases as well. I'm waiting for > > reviews. > > ok, I'll rebase this to acme/tmp.perf/hpp
well, you can, but that one is buggy and you will not be able to test 'perf diff' at all...
- Arnaldo
| |