Messages in this thread | | | Date | Thu, 6 Sep 2012 12:03:07 +0200 | From | Martin Pitt <> | Subject | [PATCH 0/1] Option for scsi_debug to fake removable devices |
| |
Hello all,
I already re-sent this 1.5 months ago, but did not get any answer back then; I guess it got lost in the noise by now. So, patiently retrying again.
For the purposes of automatically testing udisks and gvfs automounting I would like to add a parameter to scsi_debug to control the "removable" attribute of the created block device. With that, we can test system-internal and removable drives, as well as CD-ROMs (which scsi_debug can already emulate). udisks requires different privileges for mounting system-internal drives vs. removable/hotpluggable drives. This will also allow us to write system integration tests for gvfs, which will exercise the whole stack including the actual polkit configuration in a VM.
I wrote a simple kernel patch for this (against linux-next), and tested this quite thoroughly.
I ran the style checker, and it reports two problems:
------------ 8< -------------- WARNING: line over 80 characters #109: FILE: drivers/scsi/scsi_debug.c:3255: + ret |= driver_create_file(&sdebug_driverfs_driver, &driver_attr_removable);
WARNING: Prefer pr_err(... to printk(KERN_ERR, ... #126: FILE: drivers/scsi/scsi_debug.c:3353: + printk(KERN_ERR "scsi_debug_init: removable must be 0 or 1\n"); ------------ 8< --------------
But as the existing code uses this style in the adjacent lines, I favored consistency over fixing those. If the latter is desired, I'd rather send a separate patch with just the style cleanup for the whole file.
I got an ack from David Zeuthen (the primary udisks maintainer) already, noted so in the patch.
Thank you in advance for considering,
Martin
-- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) [unhandled content-type:application/pgp-signature] | |