lkml.org 
[lkml]   [2012]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] virtio-blk: Fix kconfig option
On Wed, Sep 05, 2012 at 12:22:58PM +0800, Asias He wrote:
> On 09/04/2012 02:23 PM, Rusty Russell wrote:
> > Kent Overstreet <koverstreet@google.com> writes:
> >
> >> CONFIG_VIRTIO isn't exposed, everything else is supposed to select it
> >> instead.
> >
> > This is a slight mis-understanding. It's supposed to be selected by
> > the particular driver, probably virtio_pci in your case.
>
> virtio_mmio selects virtio as well.
>
> drivers/virtio/Kconfig
> config VIRTIO_MMIO
> select VIRTIO
> config VIRTIO_PCI
> select VIRTIO
>
> How about this:
> config VIRTIO_BLK
> depends on EXPERIMENTAL && (VIRTIO_PCI || VIRTIO_MMIO)

Isn't this exactly what depends on VIRTIO achieves?

> --
> Asias


\
 
 \ /
  Last update: 2012-09-05 09:02    [W:0.066 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site