Messages in this thread | | | Date | Wed, 5 Sep 2012 09:04:41 +0300 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH] virtio-blk: Fix kconfig option |
| |
On Wed, Sep 05, 2012 at 01:54:07PM +0800, Asias He wrote: > On 09/05/2012 01:48 PM, Michael S. Tsirkin wrote: > > On Wed, Sep 05, 2012 at 12:22:58PM +0800, Asias He wrote: > >> On 09/04/2012 02:23 PM, Rusty Russell wrote: > >>> Kent Overstreet <koverstreet@google.com> writes: > >>> > >>>> CONFIG_VIRTIO isn't exposed, everything else is supposed to select it > >>>> instead. > >>> > >>> This is a slight mis-understanding. It's supposed to be selected by > >>> the particular driver, probably virtio_pci in your case. > >> > >> virtio_mmio selects virtio as well. > >> > >> drivers/virtio/Kconfig > >> config VIRTIO_MMIO > >> select VIRTIO > >> config VIRTIO_PCI > >> select VIRTIO > >> > >> How about this: > >> config VIRTIO_BLK > >> depends on EXPERIMENTAL && (VIRTIO_PCI || VIRTIO_MMIO) > > > > Isn't this exactly what depends on VIRTIO achieves? > > Yes. But this gives the information that virtio_blk depends on one of > the virtio transport: virito_pci or virtio_mmio.
It can work with any transport.
> -- > Asias
| |