Messages in this thread | | | Date | Wed, 5 Sep 2012 13:46:21 +0100 | From | Alan Cox <> | Subject | Re: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs |
| |
On Wed, 5 Sep 2012 03:29:32 +0100 Matthew Garrett <mjg@redhat.com> wrote:
> On Tue, Sep 04, 2012 at 10:18:48PM -0400, Don Dutile wrote: > > > /* > > >+ * Some devices may provide ROMs via a source other than the BAR > > >+ */ > > >+ if (pdev->rom&& pdev->romlen) { > > >+ *size = pdev->romlen; > > >+ return phys_to_virt((phys_addr_t)pdev->rom); > > ^^^^^ > > ioremap_nocache() ? ... or is caching rom ok? > > If it's appearing through this pathway then it's not actually in ROM, > the platform has pulled it out of somewhere else.
If that somewhere else is on the PCI bus then it should be a bus not a virt translation surely ?
| |