lkml.org 
[lkml]   [2012]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs
On Wed, 5 Sep 2012 03:29:32 +0100
Matthew Garrett <mjg@redhat.com> wrote:

> On Tue, Sep 04, 2012 at 10:18:48PM -0400, Don Dutile wrote:
> > > /*
> > >+ * Some devices may provide ROMs via a source other than the BAR
> > >+ */
> > >+ if (pdev->rom&& pdev->romlen) {
> > >+ *size = pdev->romlen;
> > >+ return phys_to_virt((phys_addr_t)pdev->rom);
> > ^^^^^
> > ioremap_nocache() ? ... or is caching rom ok?
>
> If it's appearing through this pathway then it's not actually in ROM,
> the platform has pulled it out of somewhere else.

If that somewhere else is on the PCI bus then it should be a bus not a
virt translation surely ?


\
 
 \ /
  Last update: 2012-09-05 15:23    [W:0.064 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site