Messages in this thread | | | Date | Wed, 5 Sep 2012 03:29:32 +0100 | From | Matthew Garrett <> | Subject | Re: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs |
| |
On Tue, Sep 04, 2012 at 10:18:48PM -0400, Don Dutile wrote: > > /* > >+ * Some devices may provide ROMs via a source other than the BAR > >+ */ > >+ if (pdev->rom&& pdev->romlen) { > >+ *size = pdev->romlen; > >+ return phys_to_virt((phys_addr_t)pdev->rom); > ^^^^^ > ioremap_nocache() ? ... or is caching rom ok?
If it's appearing through this pathway then it's not actually in ROM, the platform has pulled it out of somewhere else.
-- Matthew Garrett | mjg59@srcf.ucam.org
| |