lkml.org 
[lkml]   [2012]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Drbd-dev] [PATCH] drbd: use list_move_tail instead of list_del/list_add_tail
Date

Thanks, applied.

Best regards,
Phil
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/block/drbd/drbd_worker.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/drbd/drbd_worker.c
> b/drivers/block/drbd/drbd_worker.c index 6bce2cc..a196281 100644
> --- a/drivers/block/drbd/drbd_worker.c
> +++ b/drivers/block/drbd/drbd_worker.c
> @@ -141,8 +141,7 @@ static void drbd_endio_write_sec_final(struct
> drbd_epoch_entry *e) __releases(lo
>
> spin_lock_irqsave(&mdev->req_lock, flags);
> mdev->writ_cnt += e->size >> 9;
> - list_del(&e->w.list); /* has been on active_ee or sync_ee */
> - list_add_tail(&e->w.list, &mdev->done_ee);
> + list_move_tail(&e->w.list, &mdev->done_ee);
>
> /* No hlist_del_init(&e->collision) here, we did not send the Ack yet,
> * neither did we wake possibly waiting conflicting requests.
>
>
> _______________________________________________
> drbd-dev mailing list
> drbd-dev@lists.linbit.com
> http://lists.linbit.com/mailman/listinfo/drbd-dev


\
 
 \ /
  Last update: 2012-09-05 15:23    [W:0.068 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site