Messages in this thread | | | Date | Tue, 4 Sep 2012 17:47:54 +0300 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH 5/5] virtio-scsi: introduce multiqueue support |
| |
On Tue, Aug 28, 2012 at 01:54:17PM +0200, Paolo Bonzini wrote: > @@ -575,15 +630,19 @@ static struct scsi_host_template virtscsi_host_template = { > &__val, sizeof(__val)); \ > }) > > +
Pls don't add empty lines.
> static void virtscsi_init_vq(struct virtio_scsi_vq *virtscsi_vq, > - struct virtqueue *vq) > + struct virtqueue *vq, bool affinity) > { > spin_lock_init(&virtscsi_vq->vq_lock); > virtscsi_vq->vq = vq; > + if (affinity) > + virtqueue_set_affinity(vq, virtqueue_get_queue_index(vq) - > + VIRTIO_SCSI_VQ_BASE); > } >
This means in practice if you have less virtqueues than CPUs, things are not going to work well, will they?
Any idea what to do?
-- MST
| |