lkml.org 
[lkml]   [2012]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] virtio-scsi: introduce multiqueue support
Il 04/09/2012 16:47, Michael S. Tsirkin ha scritto:
>> > static void virtscsi_init_vq(struct virtio_scsi_vq *virtscsi_vq,
>> > - struct virtqueue *vq)
>> > + struct virtqueue *vq, bool affinity)
>> > {
>> > spin_lock_init(&virtscsi_vq->vq_lock);
>> > virtscsi_vq->vq = vq;
>> > + if (affinity)
>> > + virtqueue_set_affinity(vq, virtqueue_get_queue_index(vq) -
>> > + VIRTIO_SCSI_VQ_BASE);
>> > }
>> >
> This means in practice if you have less virtqueues than CPUs,
> things are not going to work well, will they?

Not particularly. It could be better or worse than single queue
depending on the workload.

> Any idea what to do?

Two possibilities:

1) Add a stride argument to virtqueue_set_affinity, and make it equal to
the number of queues.

2) Make multiqueue the default in QEMU, and make the default number of
queues equal to the number of VCPUs.

I was going for (2).

Paolo


\
 
 \ /
  Last update: 2012-09-04 17:43    [W:0.288 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site