Messages in this thread | | | Date | Fri, 28 Sep 2012 20:16:39 +0530 | From | "Srivatsa S. Bhat" <> | Subject | Re: [PATCH] CPU hotplug, writeback: Don't call writeback_set_ratelimit() too often during hotplug |
| |
On 09/28/2012 05:57 PM, Fengguang Wu wrote: > On Tue, Sep 25, 2012 at 02:18:20AM +0530, Srivatsa S. Bhat wrote: >> >> From: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> >> >> The CPU hotplug callback related to writeback calls writeback_set_ratelimit() >> during every state change in the hotplug sequence. This is unnecessary >> since num_online_cpus() changes only once during the entire hotplug operation. >> >> So invoke the function only once per hotplug, thereby avoiding the >> unnecessary repetition of those costly calculations. >> >> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> >> --- > > Looks good to me. I'll include it in the writeback tree. >
Great, thanks!
Regards, Srivatsa S. Bhat
| |