Messages in this thread | | | Date | Thu, 04 Oct 2012 07:11:03 +0800 | From | Ni zhan Chen <> | Subject | Re: [PATCH] CPU hotplug, writeback: Don't call writeback_set_ratelimit() too often during hotplug |
| |
On 09/28/2012 08:27 PM, Fengguang Wu wrote: > On Tue, Sep 25, 2012 at 02:18:20AM +0530, Srivatsa S. Bhat wrote: >> From: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> >> >> The CPU hotplug callback related to writeback calls writeback_set_ratelimit() >> during every state change in the hotplug sequence. This is unnecessary >> since num_online_cpus() changes only once during the entire hotplug operation. >> >> So invoke the function only once per hotplug, thereby avoiding the >> unnecessary repetition of those costly calculations. >> >> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> >> --- > Looks good to me. I'll include it in the writeback tree.
Hi Fengguang,
Could you tell me when inode->i_state & I_DIRTY will be set? thanks.
Regards, Chen
> > Thanks, > Fengguang > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >
| |