lkml.org 
[lkml]   [2012]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/57] power: ab8500_bm: Don't clear the CCMuxOffset bit
On Tue, Sep 25, 2012 at 10:11:59AM -0600, mathieu.poirier@linaro.org wrote:
> From: Kalle Komierowski <karl.komierowski@stericsson.com>
>
> The CCMuxOffset bit is not kept set, this will force the columb counter
> of the AB8500 to use the measure offset calibration.
> This should increase the accuracy of the fuel gauge.
>
> Signed-off-by: Kalle Komierowski <karl.komierowski@stericsson.com>
> Signed-off-by: Marcus Cooper <marcus.xm.cooper@stericsson.com>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Reviewed-by: Jonas ABERG <jonas.aberg@stericsson.com>
> ---
> drivers/power/ab8500_fg.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c
> index bf02225..af792a8 100644
> --- a/drivers/power/ab8500_fg.c
> +++ b/drivers/power/ab8500_fg.c
> @@ -485,8 +485,9 @@ static int ab8500_fg_coulomb_counter(struct ab8500_fg *di, bool enable)
> di->flags.fg_enabled = true;
> } else {
> /* Clear any pending read requests */
> - ret = abx500_set_register_interruptible(di->dev,
> - AB8500_GAS_GAUGE, AB8500_GASG_CC_CTRL_REG, 0);
> + ret = abx500_mask_and_set_register_interruptible(di->dev,
> + AB8500_GAS_GAUGE, AB8500_GASG_CC_CTRL_REG,
> + (RESET_ACCU | READ_REQ), 0);
> if (ret)
> goto cc_err;
>
> @@ -1404,8 +1405,7 @@ static void ab8500_fg_algorithm_discharging(struct ab8500_fg *di)
> sleep_time = di->bat->fg_params->init_timer;
>
> /* Discard the first [x] seconds */
> - if (di->init_cnt >
> - di->bat->fg_params->init_discard_time) {
> + if (di->init_cnt > di->bat->fg_params->init_discard_time) {

This change is OK, but it's cosmetic, and desires its own patch (you can
combine all cosmetic changes, which does not change the logic, into one
patch).

> ab8500_fg_calc_cap_discharge_voltage(di, true);
>
> ab8500_fg_check_capacity_limits(di, true);
> --
> 1.7.5.4


\
 
 \ /
  Last update: 2012-09-28 06:21    [W:0.325 / U:0.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site