lkml.org 
[lkml]   [2012]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 45/57] power: ab8500: defer btemp filtering while init
On Tue, Sep 25, 2012 at 10:12:42AM -0600, mathieu.poirier@linaro.org wrote:
> From: Rupesh Kumar <rupesh.kumar@stericsson.com>
>
> Due to btemp filtering enabled during init, temp values
> reported to charge algorithm driver started from 0.
> As a result,charge algorithm was going into wrong
> state and charging was stopped.
> This patch defers btemp filtering till init is done.
>
> Signed-off-by: Rupesh Kumar <rupesh.kumar@stericsson.com>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Reviewed-by: Marcus COOPER <marcus.xm.cooper@stericsson.com>
> Reviewed-by: Martin SJOBLOM <martin.w.sjoblom@stericsson.com>
> Reviewed-by: Philippe LANGLAIS <philippe.langlais@stericsson.com>
> ---
> drivers/power/ab8500_btemp.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/ab8500_btemp.c b/drivers/power/ab8500_btemp.c
> index b24835f..1f33122 100644
> --- a/drivers/power/ab8500_btemp.c
> +++ b/drivers/power/ab8500_btemp.c
> @@ -613,7 +613,6 @@ static void ab8500_btemp_periodic_work(struct work_struct *work)
> struct ab8500_btemp, btemp_periodic_work.work);
>
> if (!di->initialized) {
> - di->initialized = true;
> /* Identify the battery */
> if (ab8500_btemp_id(di) < 0)
> dev_warn(di->dev, "failed to identify the battery\n");
> @@ -626,8 +625,9 @@ static void ab8500_btemp_periodic_work(struct work_struct *work)
> * same temperature. Else only allow 1 degree change from previous
> * reported value in the direction of the new measurement.
> */
> - if (bat_temp == di->prev_bat_temp || !di->initialized) {
> - if (di->bat_temp != di->prev_bat_temp || !di->initialized) {
> + if ((bat_temp == di->prev_bat_temp) || !di->initialized) {
> + if ((di->bat_temp != di->prev_bat_temp) || !di->initialized) {

This change is stray, and adds completely unneeded parenthesis.

> + di->initialized = true;
> di->bat_temp = bat_temp;
> power_supply_changed(&di->btemp_psy);
> }
> --
> 1.7.5.4


\
 
 \ /
  Last update: 2012-09-28 03:41    [W:0.411 / U:2.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site