Messages in this thread | | | Date | Tue, 25 Sep 2012 14:57:21 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 10/19] x86, io_apic: Introduce function pointer for setup_timer_IRQ0_pin |
| |
On Sun, Aug 26, 2012 at 08:16:03PM +0200, Sebastian Andrzej Siewior wrote: > On Mon, Aug 20, 2012 at 03:55:56PM +0200, Joerg Roedel wrote: > > diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c > > index 827f8a1..71824fc 100644 > > --- a/drivers/iommu/irq_remapping.c > > +++ b/drivers/iommu/irq_remapping.c > > @@ -87,11 +87,18 @@ error: > > return ret; > > } > > > > +static void __init irq_remapping_setup_timer_pin(unsigned int ioapic_idx, > > + unsigned int pin, int vector) > > +{ > > + /* Not needed with interrupt remapping */ > > I see that this is not needed because it is empty. But *why* isn't it needed? > That comment would make sense here. So please drop this or explain :)
Well, the function is never called with interrupt-remapping enabled anyway, so it is not needed. On the other side this makes the complete patch pointless :) I'll remove it from the patch-set.
Joerg
-- AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
| |