| Date | Sun, 26 Aug 2012 20:16:03 +0200 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH 10/19] x86, io_apic: Introduce function pointer for setup_timer_IRQ0_pin |
| |
On Mon, Aug 20, 2012 at 03:55:56PM +0200, Joerg Roedel wrote: > diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c > index 827f8a1..71824fc 100644 > --- a/drivers/iommu/irq_remapping.c > +++ b/drivers/iommu/irq_remapping.c > @@ -87,11 +87,18 @@ error: > return ret; > } > > +static void __init irq_remapping_setup_timer_pin(unsigned int ioapic_idx, > + unsigned int pin, int vector) > +{ > + /* Not needed with interrupt remapping */
I see that this is not needed because it is empty. But *why* isn't it needed? That comment would make sense here. So please drop this or explain :)
> +} > +
Sebastian
|