Messages in this thread Patch in this message | | | Date | Tue, 25 Sep 2012 16:08:52 +0400 | From | Cyrill Gorcunov <> | Subject | [PATCH] prctl: Use access_ok instead of TASK_SIZE in prctl_set_mm |
| |
Eric pointed that better to use access_ok instead of TASK_SIZE for testing if address is allowed for use.
Reported-by: "Eric W. Biederman" <ebiederm@xmission.com> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> CC: Mark Salter <msalter@redhat.com> CC: Kees Cook <keescook@chromium.org> CC: Andrew Morton <akpm@linux-foundation.org> CC: Pavel Emelyanov <xemul@parallels.com> --- kernel/sys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.git/kernel/sys.c =================================================================== --- linux-2.6.git.orig/kernel/sys.c +++ linux-2.6.git/kernel/sys.c @@ -1865,7 +1865,7 @@ static int prctl_set_mm(int opt, unsigne if (opt == PR_SET_MM_EXE_FILE) return prctl_set_mm_exe_file(mm, (unsigned int)addr); - if (addr >= TASK_SIZE || addr < mmap_min_addr) + if (!access_ok(VERIFY_READ, addr, sizeof(addr)) || addr < mmap_min_addr) return -EINVAL; error = -EINVAL;
| |