lkml.org 
[lkml]   [2012]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] staging/csr: clean coding style in uf_start_thread
This was sent encoded as base64 which is awkward.

On Sat, Aug 04, 2012 at 01:01:38PM +0545, Devendra Naga wrote:
> - } else {
> - priv->bh_thread.prio = DEFAULT_PRIO;
> - }
> + } else
> + priv->bh_thread.prio = DEFAULT_PRIO;

Probably it's not worth resending if this is the only complaint, but
actually the original had that braces correct. If either side of
the if else statement gets uses curly braces then both sides should
use them.

regards,
dan carpenter


\
 
 \ /
  Last update: 2012-08-06 16:42    [W:0.337 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site