lkml.org 
[lkml]   [2012]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs
From
Date
On Sun, 2012-08-26 at 13:21 -0400, Huang Shijie wrote:
> This patch is based on the assumption that all the partitions are
> in the right offset order.
>
> Assume we have a 1GB(8Gb) nand chip, and we set the partitions
> in the command line like this:
> #gpmi-nand:100m(boot),100m(kernel),1g(rootfs)
>
> In this case, the partition truncating occurs. The current code will
> get the following result:
>
> ----------------------------------
> root@freescale ~$ cat /proc/mtd
> dev: size erasesize name
> mtd0: 06400000 00040000 "boot"
> mtd1: 06400000 00040000 "kernel"
> ----------------------------------
>
> It is obvious that we lost the truncated partition `rootfs` which should
> be 824M in this case.
>
> Why? The old code sets the wrong partitions number when the truncating
> occurs. This patch fixes it. Alao add a `break` to shortcut the code in this
> case.
>
> After apply this patch, the result becomes:
> ----------------------------------
> root@freescale ~$ cat /proc/mtd
> dev: size erasesize name
> mtd0: 06400000 00040000 "boot"
> mtd1: 06400000 00040000 "kernel"
> mtd2: 33800000 00040000 "rootfs"
> ----------------------------------
>
> We get the right result.
>
> Signed-off-by: Huang Shijie <shijie8@gmail.com>

Should this have CC to -stable?

--
Best Regards,
Artem Bityutskiy
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-08-30 09:21    [W:0.096 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site