Messages in this thread | | | Date | Fri, 31 Aug 2012 09:36:27 -0400 | Subject | Re: [PATCH 1/3] mtd: cmdlinepart: make the partitions rule more strict | From | Huang Shijie <> |
| |
On Fri, Aug 31, 2012 at 7:45 AM, Artem Bityutskiy <dedekind1@gmail.com> wrote: > On Sun, 2012-08-26 at 13:21 -0400, Huang Shijie wrote: >> There are typically two types to set the mtd partitions: >> >> <1> set with the `size`, such as >> gpmi-nand:100m(boot),100m(kernel),1g(rootfs) >> >> <2> set with the `offset`, such as >> gpmi-nand:100m@0(boot),100m@100m(kernel),1g@200m(rootfs) >> gpmi-nand:1g@200m(rootfs),100m@0(boot),100m@100m(kernel) >> >> If we mix these two types, such as: >> gpmi-nand:100m@0(boot),100m(kernel),1g@200m(rootfs) >> gpmi-nand:1g@200m(rootfs),100m@0(boot),100m(kernel) >> >> It's hard to understand the cmdline. And also it is hard to sort the >> partitions in this mixed type. So we explicitly forbid the mixed type. > > So "explicitly forbid" is just to add a "do not do this" comment? >
This is the simplest way. ;)
It's make code complicated if we change the code to forbid this mixed type.
Best Regards Huang Shijie
| |