Messages in this thread | | | Date | Fri, 17 Aug 2012 13:28:53 +0200 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface |
| |
On 08/17/2012 01:02 PM, Felipe Balbi wrote: > On Fri, Aug 17, 2012 at 01:01:44PM +0200, Sebastian Andrzej Siewior wrote: >> On 08/17/2012 12:51 PM, Felipe Balbi wrote: >>>> Sounds reasonable? >>> >>> no it doesn't. Please remove that static global. Sorry but one of the >>> goals with udc_start/udc_stop was really to get rid of all those >>> nonsensical static globals. >> >> I wouldn't insist on it. If you look at pxa25x, " static struct >> pxa25x_udc memory = {" they do the same thing. It is only a simple way >> to onetime initialize variables. > > fair enough. Though that's wrong too and should be changed. The whole > idea of allowing multiple UDCs on the same kernel image is mostly to aid > development. Specially on pre-silicon phase. We could have a bunch of > PCIe FPGA boards and instantiate a different controller on each one and > have the same kernel work with them all.
True. And he said he is going to fix it once they have multiple UDC. I didn't remove the global thingy from any driver I converted if it was used as a way to easy initialize things. And I kept only one reference to it in the probe code. This is the only thing I ask for.
Sebastian
| |