lkml.org 
[lkml]   [2012]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface
On 08/17/2012 12:51 PM, Felipe Balbi wrote:
>> Sounds reasonable?
>
> no it doesn't. Please remove that static global. Sorry but one of the
> goals with udc_start/udc_stop was really to get rid of all those
> nonsensical static globals.

I wouldn't insist on it. If you look at pxa25x, " static struct
pxa25x_udc memory = {" they do the same thing. It is only a simple way
to onetime initialize variables.

Sebastian


\
 
 \ /
  Last update: 2012-08-17 13:41    [W:0.785 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site