Messages in this thread | | | Date | Fri, 17 Aug 2012 13:01:44 +0200 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH] usb: gadget: lpc32xx_udc: Port to new start/stop interface |
| |
On 08/17/2012 12:51 PM, Felipe Balbi wrote: >> Sounds reasonable? > > no it doesn't. Please remove that static global. Sorry but one of the > goals with udc_start/udc_stop was really to get rid of all those > nonsensical static globals.
I wouldn't insist on it. If you look at pxa25x, " static struct pxa25x_udc memory = {" they do the same thing. It is only a simple way to onetime initialize variables.
Sebastian
| |