Messages in this thread | | | From | "Ren, Cloud" <> | Subject | RE: [PATCH] net: add new QCA alx ethernet driver | Date | Thu, 16 Aug 2012 02:19:16 +0000 |
| |
From: Stephen Hemminger [mailto:shemminger@vyatta.com] Sent: Wednesday, August 15, 2012 11:02 PM
>> >>>> + strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - >1); >> >>>> ... >> >>>> + strcpy(netdev->name, "eth%d"); >> >>>> + retval = register_netdev(netdev); >> >>> >> >>>The strcpy is unnecessary, alloc_etherdev already sets that. >> >> >> >> The strcpy is useful. netdev->name is set as pci_name in front. So the strcpy >> >restores it. >> > >> >Are you doing this just to influence the initial driver log messages? >> >> Yes. >> >> > >> >Don't do that, it's gross. >> >> Ok, I will remove it. > >Before the driver is registered, use dev_info() type of logging.
Ok, I will do.
| |