lkml.org 
[lkml]   [2012]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] net: add new QCA alx ethernet driver
Date
From: Stephen Hemminger [mailto:shemminger@vyatta.com]
Sent: Wednesday, August 15, 2012 11:02 PM

>> >>>> + strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) -
>1);
>> >>>> ...
>> >>>> + strcpy(netdev->name, "eth%d");
>> >>>> + retval = register_netdev(netdev);
>> >>>
>> >>>The strcpy is unnecessary, alloc_etherdev already sets that.
>> >>
>> >> The strcpy is useful. netdev->name is set as pci_name in front. So the strcpy
>> >restores it.
>> >
>> >Are you doing this just to influence the initial driver log messages?
>>
>> Yes.
>>
>> >
>> >Don't do that, it's gross.
>>
>> Ok, I will remove it.
>
>Before the driver is registered, use dev_info() type of logging.

Ok, I will do.








\
 
 \ /
  Last update: 2012-08-16 05:03    [W:0.611 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site