Messages in this thread | | | From | "Ren, Cloud" <> | Subject | RE: [PATCH] net: add new QCA alx ethernet driver | Date | Wed, 15 Aug 2012 05:39:11 +0000 |
| |
From: David Miller [mailto:davem@davemloft.net] Sent: Wednesday, August 15, 2012 1:33 PM
>From: "Ren, Cloud" <cjren@qca.qualcomm.com> >Date: Wed, 15 Aug 2012 03:29:26 +0000 > >>>> + strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1); >>>> ... >>>> + strcpy(netdev->name, "eth%d"); >>>> + retval = register_netdev(netdev); >>> >>>The strcpy is unnecessary, alloc_etherdev already sets that. >> >> The strcpy is useful. netdev->name is set as pci_name in front. So the strcpy >restores it. > >Are you doing this just to influence the initial driver log messages?
Yes.
> >Don't do that, it's gross.
Ok, I will remove it.
| |