Messages in this thread Patch in this message | | | From | Joonsoo Kim <> | Subject | [PATCH 1/2] slub: reduce failure of this_cpu_cmpxchg in put_cpu_partial() after unfreezing | Date | Thu, 16 Aug 2012 00:02:39 +0900 |
| |
In current implementation, after unfreezing, we doesn't touch oldpage, so it remain 'NOT NULL'. When we call this_cpu_cmpxchg() with this old oldpage, this_cpu_cmpxchg() is mostly be failed.
We can change value of oldpage to NULL after unfreezing, because unfreeze_partial() ensure that all the cpu partial slabs is removed from cpu partial list. In this time, we could expect that this_cpu_cmpxchg is mostly succeed.
Signed-off-by: Joonsoo Kim <js1304@gmail.com> Cc: Christoph Lameter <cl@linux.com> Cc: David Rientjes <rientjes@google.com> Acked-by: Christoph Lameter <cl@linux.com>
--- Hello, Pekka.
These two patches get "Acked-by: Christoph Lameter <cl@linux.com>", but, I don't hear any answer from U. Could you review these, please?
Thanks!
diff --git a/mm/slub.c b/mm/slub.c index e517d43..ca778e5 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1952,6 +1952,7 @@ int put_cpu_partial(struct kmem_cache *s, struct page *page, int drain) local_irq_save(flags); unfreeze_partials(s); local_irq_restore(flags); + oldpage = NULL; pobjects = 0; pages = 0; stat(s, CPU_PARTIAL_DRAIN); -- 1.7.9.5
| |