Messages in this thread | | | Subject | regulator: Does it make sense to set the same ops for [en|dis]able and set_suspend_[en|dis]able? | From | Axel Lin <> | Date | Fri, 06 Jul 2012 10:36:27 +0800 |
| |
Just wandering does it make sense to set the same ops for [en|dis]able and set_suspend_[en|dis]able callbacks.
Or these drivers need fix?
max8952: static struct regulator_ops max8952_ops = { .list_voltage = max8952_list_voltage, .is_enabled = max8952_is_enabled, .enable = max8952_enable, .disable = max8952_disable, .get_voltage_sel = max8952_get_voltage_sel, .set_voltage_sel = max8952_set_voltage_sel, .set_suspend_disable = max8952_disable, };
max8998: static struct regulator_ops max8998_ldo_ops = { .list_voltage = max8998_list_voltage, .is_enabled = max8998_ldo_is_enabled, .enable = max8998_ldo_enable, .disable = max8998_ldo_disable, .get_voltage_sel = max8998_get_voltage_sel, .set_voltage = max8998_set_voltage_ldo, .set_suspend_enable = max8998_ldo_enable, .set_suspend_disable = max8998_ldo_disable, };
static struct regulator_ops max8998_buck_ops = { .list_voltage = max8998_list_voltage, .is_enabled = max8998_ldo_is_enabled, .enable = max8998_ldo_enable, .disable = max8998_ldo_disable, .get_voltage_sel = max8998_get_voltage_sel, .set_voltage = max8998_set_voltage_buck, .set_voltage_time_sel = max8998_set_voltage_buck_time_sel, .set_suspend_enable = max8998_ldo_enable, .set_suspend_disable = max8998_ldo_disable, };
static struct regulator_ops max8998_others_ops = { .is_enabled = max8998_ldo_is_enabled, .enable = max8998_ldo_enable, .disable = max8998_ldo_disable, .set_suspend_enable = max8998_ldo_enable, .set_suspend_disable = max8998_ldo_disable, };
| |