Messages in this thread Patch in this message | | | From | Sebastian Andrzej Siewior <> | Subject | [PATCH] uprobes: don't enable/disable signle step if the user did it | Date | Thu, 26 Jul 2012 17:20:43 +0200 |
| |
If someone is using single stepping over uprobe brackpoint then after we pass the uprobe single step, single stepping is disabled and the user who enebaled them in the first place does not know anything about this.
This patch avoids enabling / disabling the single step mode if it is already enabled.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- include/linux/uprobes.h | 2 ++ kernel/events/uprobes.c | 10 ++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h index efe4b33..1be2d44 100644 --- a/include/linux/uprobes.h +++ b/include/linux/uprobes.h @@ -44,6 +44,8 @@ struct inode; #define UPROBE_RUN_HANDLER 0x2 /* Can skip singlestep */ #define UPROBE_SKIP_SSTEP 0x4 +/* user does also singlestep */ +#define UPROBE_USER_SSTEP 0x8 struct uprobe_consumer { int (*handler)(struct uprobe_consumer *self, struct pt_regs *regs); diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index f935327..772eb3a 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -1528,7 +1528,10 @@ static void handle_swbp(struct pt_regs *regs) utask->state = UTASK_SSTEP; if (!pre_ssout(uprobe, regs, bp_vaddr)) { - user_enable_single_step(current); + if (test_tsk_thread_flag(current, TIF_SINGLESTEP)) + uprobe->flags |= UPROBE_USER_SSTEP; + else + user_enable_single_step(current); return; } @@ -1569,7 +1572,10 @@ static void handle_singlestep(struct uprobe_task *utask, struct pt_regs *regs) put_uprobe(uprobe); utask->active_uprobe = NULL; utask->state = UTASK_RUNNING; - user_disable_single_step(current); + if (uprobe->flags & UPROBE_USER_SSTEP) + uprobe->flags &= ~UPROBE_USER_SSTEP; + else + user_disable_single_step(current); xol_free_insn_slot(current); spin_lock_irq(¤t->sighand->siglock); -- 1.7.10.4
| |