lkml.org 
[lkml]   [2012]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectFalse warning from Sparse
Hi,

I am getting the following false warning from sparse:

CHECK drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:1158:13: warning: context
imbalance in 'rtl92c_dm_refresh_rate_adaptive_mask' - different lock contexts
for basic block

The only code in that routine that does any locking is the following:

/* Only the PCI card uses sta in the update rate table
* callback routine */
if (rtlhal->interface == INTF_PCI) {
rcu_read_lock();
sta = ieee80211_find_sta(mac->vif, mac->bssid);
}
rtlpriv->cfg->ops->update_rate_tbl(hw, sta,
p_ra->ratr_state);

p_ra->pre_ratr_state = p_ra->ratr_state;
if (rtlhal->interface == INTF_PCI)
rcu_read_unlock();

Does the warning get output because the code cannot assume that
rtlhal->interface is the same in both if statements? If that is the case, are
there any compiler directives that would tell sparse of the situation?

Thanks,

Larry


\
 
 \ /
  Last update: 2012-07-22 06:01    [W:0.022 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site