Messages in this thread Patch in this message | | | Date | Fri, 20 Jul 2012 09:56:23 +0300 | From | Dan Carpenter <> | Subject | [patch] driver-core: dev_to_node() should handle NULL pointers |
| |
What prompted this patch is that in dma_pool_create() we call dev_to_node() before checking whether "dev" is NULL. It looks like there are places which call dma_pool_create() with a NULL pointer. An example is in drivers/usb/gadget/amd5536udc.c.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- Static checker fix.
diff --git a/include/linux/device.h b/include/linux/device.h index aa7b3b4..c80e7a8d 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -714,7 +714,9 @@ int dev_set_name(struct device *dev, const char *name, ...); #ifdef CONFIG_NUMA static inline int dev_to_node(struct device *dev) { - return dev->numa_node; + if (dev) + return dev->numa_node; + return -1; } static inline void set_dev_node(struct device *dev, int node) {
| |