Messages in this thread | | | Subject | Re: [PATCH 04/13] rbtree: move some implementation details from rbtree.h to rbtree.c | Date | Wed, 11 Jul 2012 17:48:37 +0200 | From | "Michal Nazarewicz" <> |
| |
On Wed, 11 Jul 2012 01:12:54 +0200, Michel Lespinasse <walken@google.com> wrote:
> On Tue, Jul 10, 2012 at 5:19 AM, Michal Nazarewicz <mina86@mina86.com> wrote: >> On Tue, 10 Jul 2012 01:35:14 +0200, Michel Lespinasse <walken@google.com> wrote: >>> +#define RB_RED 0 >>> +#define RB_BLACK 1 >> >> Interestingly, those are almost never used. RB_BLACK is used only once. >> Should we get rid of those instead? Or change the code (like rb_is_red()) >> to use them? > > I'm actually making heavier use of RB_RED / RB_BLACK later on in the patch set.
Yeah, I've just noticed. Disregard my comment.
> But agree, rb_is_red() / rb_is_black() could use these too.
-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |