Messages in this thread | | | Date | Tue, 10 Jul 2012 16:12:54 -0700 | Subject | Re: [PATCH 04/13] rbtree: move some implementation details from rbtree.h to rbtree.c | From | Michel Lespinasse <> |
| |
On Tue, Jul 10, 2012 at 5:19 AM, Michal Nazarewicz <mina86@mina86.com> wrote: > On Tue, 10 Jul 2012 01:35:14 +0200, Michel Lespinasse <walken@google.com> wrote: >> +#define RB_RED 0 >> +#define RB_BLACK 1 > > Interestingly, those are almost never used. RB_BLACK is used only once. > Should we get rid of those instead? Or change the code (like rb_is_red()) > to use them?
I'm actually making heavier use of RB_RED / RB_BLACK later on in the patch set. But agree, rb_is_red() / rb_is_black() could use these too.
-- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.
| |