Messages in this thread | | | Subject | Re: [PATCH] perf: Fix intel shared extra msr allocation | From | Peter Zijlstra <> | Date | Tue, 05 Jun 2012 12:27:51 +0200 |
| |
On Tue, 2012-06-05 at 12:21 +0200, Stephane Eranian wrote: > I agree with the first part of the patch in intel_try_alt_er(), we > should not touch > the actual event struct. But I am still unclear about the reg->alloc part.
reg->alloc is part of the actual event.
Thing is, the patch is horridly ugly.. while I agree that changing event state isn't good, special casing all that code isn't good either.
I was looking at cloning the events for validate_group() as well, but so far that's not turning out too pretty either.
| |