Messages in this thread | | | Subject | Re: [PATCH] perf: Fix intel shared extra msr allocation | From | Peter Zijlstra <> | Date | Tue, 05 Jun 2012 12:14:31 +0200 |
| |
On Fri, 2012-06-01 at 22:11 +0800, Yan, Zheng wrote: > > The real problem is from __intel_shared_reg_put_constraints(). it set > reg->alloc to 0
ok
> and decreases fake_cpuc->shared_regs->regs[reg->idx]'s > reference count.
So? That's fake state, who cares what its left in?
> Later when deleting the event, put_constraints() will find > reg->alloc is 0 and it won't decrease the shared msr's reference count.
OK, so the only problem is us setting reg->alloc to 0?
| |