Messages in this thread Patch in this message | | | From | Devendra Naga <> | Subject | [PATCH 2/2] pinctrl: free if of_get_parent fails to get the parent node | Date | Sat, 2 Jun 2012 22:34:37 +0530 |
| |
of_get_parent can return null if no parent node found, so the allocated new_map should be freed.
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> --- drivers/pinctrl/pinctrl-imx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c index 553ed95..82c1d80 100644 --- a/drivers/pinctrl/pinctrl-imx.c +++ b/drivers/pinctrl/pinctrl-imx.c @@ -173,8 +173,10 @@ static int imx_dt_node_to_map(struct pinctrl_dev *pctldev, /* create mux map */ parent = of_get_parent(np); - if (!parent) + if (!parent) { + kfree(new_map); return -EINVAL; + } new_map[0].type = PIN_MAP_TYPE_MUX_GROUP; new_map[0].data.mux.function = parent->name; new_map[0].data.mux.group = np->name; -- 1.7.9.5
| |