lkml.org 
[lkml]   [2012]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2 v2][resend] gpio: pcf857x: enable gpio_to_irq() support

Hi Paul

> On Thu, Jun 14, 2012 at 12:10:59AM -0700, Kuninori Morimoto wrote:
> > + for (i = 0; i < gpio->chip.ngpio; i++)
> > + if (change & BIT(i))
> > + generic_handle_irq(irq_find_mapping(gpio->irq_domain, i));
> > +
> You can probably get away with using for_each_set_bit() as well, which
> would simplify this a bit.
>
> Also, do you not have to worry about masking the parent IRQ while
> iterating through the dispatch loop?

This device automatically stops its IRQ until data was read.
And it is using spin_lock_irqsave(), and it needs to save prev status.
So, I guess masking parent IRQ is not needed.
But not enough/good ?

Best regards
---
Kuninori Morimoto


\
 
 \ /
  Last update: 2012-06-14 10:41    [W:0.047 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site